search

firebearstudio / importexportfree

Improve default Magento 2 Import / Export features - cron jobs, CSV , XML , JSON , Excel , mapping of any format, Google Sheet, data and price modification, improved speed and a lot more!
https://firebearstudio.com/the-improved-import.html
Open Software License 3.0
180 stars 68 forks source link

Override of the import validation #16

Closed dmanners closed 7 years ago

dmanners commented 7 years ago

We have a system currently using the import export module. When the csv validation has issues not from the FireBear validation but from the standard Magento import validation process these will get overridden.

In the Firebear\ImportExport\Model\Job\Processor::process method when it catches an exception it will load the history and set the summary. But the Magento validation has already added the appropriate log messages to the history for this process. The end result is that when you get <b>Data validation is failed. Please fix errors and re-upload the file..</b> in the summary and not the "real" error message as provided by the Magento core import validation.

biotech commented 7 years ago

Hi David! Thanks for you notice, we will for sure fix that. We are working now on complete refactoring and improved achitecture of paid version, will be released soon and available for downloads for all customers

dmanners commented 7 years ago

Thank you for the information @biotech