search

firebelley / godot-export

Automatically exports your Godot games.
MIT License
460 stars 53 forks source link

Cache restore causes Godot URL changes to be ignored #118

Closed Spartan322 closed 11 months ago

Spartan322 commented 11 months ago

When restoring the Godot files from the cache, this action completely ignores a new url for no reason, the cache should not restore a key from a different file, this makes it impossible to use the cache functionality and update their exports. (or change your download urls for any reason)

https://github.com/firebelley/godot-export/blob/0da3bb23926ed172b2e22eba94c21807cc56951f/src/godot.ts#L113

should become

  const restoreKey = `godot-templates-${GODOT_TEMPLATES_DOWNLOAD_URL}`;

and

https://github.com/firebelley/godot-export/blob/0da3bb23926ed172b2e22eba94c21807cc56951f/src/godot.ts#L120

should become

  const restoreKey = `godot-executable-${GODOT_DOWNLOAD_URL}`;

See #119