search

firebelley / godot-export

Automatically exports your Godot games.
MIT License
486 stars 59 forks source link

add zip_export option for #16 #17

Closed tylerecouture closed 4 years ago

tylerecouture commented 4 years ago

My best stab. Sorry I don't know how to run or test this.. I'm not a TS/JS developer and started using github actions yesterday! Apologies in advance for the amateur effort...

firebelley commented 4 years ago

Thanks for addressing the feedback! I just tested and it looks good. One thing I should note is these are the subdirectories that are created in the exports directory: {7D184B05-5441-4B37-B4C6-2BF1B62ED211}

It's not a user friendly name at all, but if you're OK with that then I'll go ahead and merge. The reason these are numerical are for just in case you have several exports with the same name they won't overwrite each other.

tylerecouture commented 4 years ago

Cool! I appreciate your responses and thanks for considering these changes! I'm good with this for now =) I can play around with it for my usecase and maybe as I get more familiar with this process I can PR something with a nicer naming convention and other tweaks?

firebelley commented 4 years ago

Yep I am fine with it as is, just wanted to make sure you were OK with it. I'm planning on reworking a lot of the core code at some point, so that may open up an opportunity to support better directory names.

Anyway, I am going to merge this and create a new release now!