search

firebelley / godot-export

Automatically exports your Godot games.
MIT License
461 stars 53 forks source link

Obtain new release version after export #67

Closed raffomania closed 2 years ago

raffomania commented 2 years ago

I'm uploading my game to itch.io after running the export action and would like to pass the newly released version to itch.io as well. Could you add an output to the action containing the new version?

firebelley commented 2 years ago

Hi! Can you please elaborate on your requirements? Does the output need to be an artifact or a file path? More context about your needs would be helpful in planning an enhancement.

raffomania commented 2 years ago

Thanks for your answer. I'm using the butler push action specifically, which can take either a VERSION environment variable or a VERSION_FILE pointing to a file, so both would be possible.

My first intuition was that you could use the output metadata section. Users could then forward the output into an environment variable (or write it to a file if needed). However I'm not sure how the actual setting of outputs in JS would work.

firebelley commented 2 years ago

Now that this action has been stripped down with v4.0.0, I believe that this issue is best solved with extra custom workflow steps, rather than including as functionality here. This action no longer creates releases, it simply builds the project and leaves it up to the workflow author to decide what to do with the resulting files. I believe this is the best way to suit all kinds of disparate use cases without bloating the project.

Please feel free to reopen if you have any concerns!