search

firebelley / godot-export

Automatically exports your Godot games.
MIT License
461 stars 53 forks source link

If relative_project_path is set, it should be appended when use_preset_export_path #68

Closed tom-leys closed 2 years ago

tom-leys commented 2 years ago

In Godot, if you export from a folder it is relative to res:// root.

The same should happen when you use this action.

With these settings, outputs go in /build/ (as specified in my exports file) where they should go in /game/build

- name: export game
        # Use latest version (see releases for all versions)
        uses: firebelley/godot-export@55461c5b671a5aea2ffdc01f0f3c131b5f87cabe
        with:
          # Use 3.3.2. Need Linux headless for building.
          godot_executable_download_url: https://downloads.tuxfamily.org/godotengine/3.3.3/Godot_v3.3.3-stable_linux_headless.64.zip
          godot_export_templates_download_url: https://downloads.tuxfamily.org/godotengine/3.3.3/Godot_v3.3.3-stable_export_templates.tpz
          relative_project_path: ./game/
          use_preset_export_path: true
          # relative_export_path: ./game/build/win/
          archive_export_output: false
          create_release: false
  #        base_version:  ${{ steps.tag_version.outputs.TAG_VERSION}} 
          export_debug: true
firebelley commented 2 years ago

Sorry for the delayed response. This action has been reworked so it should not be possible to implement this. Currently use_preset_export_path is relative to the root of the git repository, but I realize now that this doesn't make any sense. I will queue up this change for the next release.

firebelley commented 2 years ago

This has been added with v4.1.0

tom-leys commented 2 years ago

Thanks for considering this @firebelley :) Thanks also for the plugin.