remove old api endpoint; implement "internal_transfer" - Githubissues

fireblocks / fireblocks-sdk-js

Typescript & Javascript SDK for developers using Fireblocks API

https://docs.fireblocks.com/api/swagger-ui/

MIT License

72 stars 69 forks source link

remove old api endpoint; implement "internal_transfer" #219

Open canvas-warwick opened 1 year ago

canvas-warwick commented 1 year ago

Pull Request Description

It appears there are two obsolete endpoints in the code: transfer_to_subaccount and transfer_from_subaccount

Fixes (link to the issue here) I have deleted these and replaced with the newer version internal_transfer

Type of change

Please delete options that are not relevant.

[ X ] Bug fix (non-breaking change which fixes an issue)
[ X ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

not tested

Checklist:

[ X ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have added corresponding labels to the PR