Revert mistake in updateVaultAccount - Githubissues

fireblocks / fireblocks-sdk-js

Typescript & Javascript SDK for developers using Fireblocks API

https://docs.fireblocks.com/api/swagger-ui/

MIT License

72 stars 69 forks source link

Revert mistake in updateVaultAccount #224

Closed gadiguy closed 1 year ago

gadiguy commented 1 year ago

Pull Request Description

Function updateVaultAccount used post instead of put, and had a redundant parameter. This commit fixes that.

Fixes (link to the issue here)

Type of change

Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Chore / Documentation
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

[X] Locally tested against Fireblocks API

Checklist:

[X] I have performed a self-review of my own code
[n/a ] I have made corresponding changes to the documentation
[X] Any dependent changes have been merged and published in downstream modules
[n/a] I have added corresponding labels to the PR