fireblocks / fireblocks-sdk-js

Typescript & Javascript SDK for developers using Fireblocks API
https://docs.fireblocks.com/api/swagger-ui/
MIT License
72 stars 69 forks source link

Fix empty querystring scenario #235

Closed AlonFireblocks closed 11 months ago

AlonFireblocks commented 11 months ago

Pull Request Description

After the latest axios upgrade from 0.27.2 to 1.6.0 for URLs with ? but no params the ? character is omitted and we get a situation that we are signing https://path/to/somwehere? but sending the request to https://path/to/somewhere, resulting with a signing error

Type of change

How Has This Been Tested?

Checklist: