fireblocks / fireblocks-sdk-js

Typescript & Javascript SDK for developers using Fireblocks API
https://docs.fireblocks.com/api/swagger-ui/
MIT License
72 stars 69 forks source link

[Bug] Missing type(s) from `TransactionStatus` enum #274

Open HarshitJoshi opened 6 months ago

HarshitJoshi commented 6 months ago

Describe the bug Some statuses related to transaction creation response seem to be missing from the TransactionStatus enum, for instance, "PENDING_ENRICHMENT"

To Reproduce Steps to reproduce the behavior:

  1. Create an ETH transaction (createTransaction)
  2. Review the response to the transaction creation request :
{
   "type":"TRANSACTION_STATUS_UPDATED",
   "tenantId":"***redacted***",
   "timestamp":1713976676073,
   "data":{
      "id":"a6c238b4-b203-4ab8-919d-afa40d244f1f",
      "createdAt":1713976661089,
      "lastUpdated":1713976661557,
      "assetId":"ETH",
      "source":{
         "id":"3",
         "type":"VAULT_ACCOUNT",
         "name":"Withdrawal 1",
         "subType":""
      },
      "destination":{
         "id":"6564f824-4c35-69f7-b392-4f956c0dade4",
         "type":"INTERNAL_WALLET",
         "name":"***redacted***",
         "subType":"Internal"
      },
      "amount":30,
      "sourceAddress":"",
      "destinationAddress":"",
      "destinationAddressDescription":"",
      "destinationTag":"",
      "status":"PENDING_ENRICHMENT",
      "txHash":"",
      "subStatus":"",
      "signedBy":[

      ],
      "createdBy":"52849aef-cd83-4de0-bb64-6963a3e30ac5",
      "rejectedBy":"",
      "amountUSD":94973.41,
      "addressType":"WHITELISTED",
      "note":"Rebalance",
      "exchangeTxId":"",
      "requestedAmount":30,
      "feeCurrency":"ETH",
      "operation":"TRANSFER",
      "customerRefId":null,
      "amountInfo":{
         "amount":"30",
         "requestedAmount":"30",
         "amountUSD":"94973.41"
      },
      "feeInfo":{

      },
      "destinations":[

      ],
      "externalTxId":null,
      "blockInfo":{

      },
      "signedMessages":[

      ],
      "assetType":"BASE_ASSET"
   }
}
  1. The fireblocks-sdk-js is missing the mapping for the status above (PENDING_ENRICHMENT).

Expected behavior TransactionStatus to contain all expected mappings related to Transaction statuses.

Version: