fireblocks / fireblocks-sdk-js

Typescript & Javascript SDK for developers using Fireblocks API
https://docs.fireblocks.com/api/swagger-ui/
MIT License
72 stars 69 forks source link

NCW Asset Response for Balance and Refresh Balance differs from that … #292

Closed nicholasjpanella closed 2 months ago

nicholasjpanella commented 3 months ago

…of Custodial APIs, extended existing type to accommodate

Pull Request Description

I've created a patch to match the static typing to the API response of NCW Get Balance and Refresh Balance endpoints

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

goweiss commented 2 months ago

Eventually we decided to change the data from balance-service (align with vault balance). See JIRA ticket