search

fireblocks / fireblocks-sdk-py

Official Python SDK for Fireblocks API
http://docs.fireblocks.com/api/swagger-ui/
MIT License
51 stars 40 forks source link

Bug introduced in 1.6.3 with `treat_as_gross_amount` #45

Closed shuckc closed 2 years ago

shuckc commented 2 years ago

Release 1.6.3 in 7e3d66c you've removed treat_as_gross_amount from the arguments list, but not from the body preparation, so create_transaction does not work:

Traceback (most recent call last):
  File "/xxx/enricher.py", line 1147, in post
    tx_result = self.fireblocks.create_transaction(**kwargs)
  File "/xxx/venv/lib/python3.9/site-packages/fireblocks_sdk/sdk.py", line 720, in create_transaction
    if treat_as_gross_amount:
NameError: name 'treat_as_gross_amount' is not defined
yarinvak commented 2 years ago

fixed in 1.6.4 thanks for reporting