search

fireblocks / mpc-lib

GNU General Public License v3.0
147 stars 86 forks source link

catch.hpp is upgraded to v2.13.8 fixing MINSIGSTKSZ error #8

Closed kozyilmaz closed 6 months ago

kozyilmaz commented 8 months ago

catch.hpp is upgraded to last 2.x series release (v2.13.8) due to errors related to MINSIGSTKSZ the core reason is MINSIGSTKSZ is no longer constant, see on glibc > 2.33 https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=85e84fe53699fe9e392edffa993612ce08b2954a;hb=HEAD

kozyilmaz commented 8 months ago

error in macOS is as follows:

In file included from /usr/include/signal.h:328,
                 from ../../../include/tests/catch.hpp:7965,
                 from main.cpp:9:
../../../include/tests/catch.hpp:10828:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
10828 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
nadav-fireblocks commented 6 months ago

The changes included in your PR has been integrated through https://github.com/fireblocks/mpc-lib/pull/12, as this project requires a small patch on top of catch's upstream code.