search

firebolt-db / firebolt-db.github.io

Firebolt documentation
Other
5 stars 63 forks source link

FIR-28289 Change SUBSTRING's <start> and <count> parameters to BIGINT #196

Open zlifb opened 10 months ago

zlifb commented 10 months ago

PackDB PR: https://github.com/firebolt-analytics/packdb/pull/8531 .

We used to define the signature of substring function following PostgreSQL, which has <start> and <count> parameters defined as INTEGER. Calling substring with BIGINT values for these parameters fail in PostgreSQL, and we kept the same behavior.

However, we agreed that this is not very convenient. Supporting BIGINT types for these parameters should be a natural extension. It does not hurt our "PostgreSQL compliant" claim. In addition, given that we still produce BIGINT for arithmetic addition of integers, this is just convenient for our user to make in-position call to other functions.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

molly-firebolt commented 10 months ago

Thank you for the PR @zlifb - is this behavior already live, or do we need to wait for a release version to be tagged on the ticket?

zlifb commented 10 months ago

@molly-firebolt The change is merged in master, but not included in the 3.30 release. So it will be in for 3.31 I assume. I tried to tag the Jira ticket but there seems to be no packdb-3.31 yet.