firebug / firebug.next

Next Firebug generation built on top of native Firefox developer tools
Other
229 stars 37 forks source link

Inspector is broken #150

Closed SebastianZ closed 10 years ago

SebastianZ commented 10 years ago

Test case:

  1. On this page open Firebug
  2. Switch to the Inspector panel
  3. Click the Inspector button
  4. Try to inspect something

=> Inspecting is not working.

Sebastian

farshidbeheshti commented 10 years ago

It works if: After opening Firebug, switch to the Debugger panel, and then switch to the Inspector panel.

That was why I said on the meeting it works for me, occasionally.

Farshid

fflorent commented 10 years ago

Sorry, it's harder than I thought to bisect it, because it looks to have occurred before we switched to jpm. I am unable now to use cfx on some commits (and I don't see what I did wrong). I summarize the commands here:

  1. in the addon-sdk/ folder, pull the last master changes
  2. source it using source bin/activate
  3. in the firebug.next/ folder, checkout some commit (for example f0c6c40 )
  4. run cfx run -o -b ~/firefox-nightly/firefox

I get this error doing so:

console.error: firebug-next: 
  Message: Module `sdk/dom/when` is not found at resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/dom/when.js
  Stack:
    CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/sdk/panel.js:27:21
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/chrome/basePanel.js:12:19
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/chrome/chrome.js:20:23
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/firebug.js:28:20
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/main.js:6:21
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/index.js:23:20
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
run@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/addon/runner.js:145:19
startup/</<@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/addon/runner.js:86:7
Handler.prototype.process@resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise-backend.js:744:7

Even if in the addon-sdk/ folder I checkout some commit in the "devtools" branch like mozilla/addon-sdk@7b19502d4d9546ac2e194f78658f8e6d1221e484, I still get this error:

console.error: firebug-next: 
  Message: Module `dev/panel` is not found at resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/dev/panel.js
  Stack:
    load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:260:32
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
require@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:367:14
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/chrome/targetWatcher.js:9:19
evaluate@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:223:19
load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:257:5
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
require@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:367:14
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/chrome/chrome.js:14:27
evaluate@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:223:19
load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:257:5
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
require@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:367:14
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/firebug.js:28:20
evaluate@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:223:19
load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:257:5
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
require@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:367:14
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/main.js:6:21
evaluate@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:223:19
load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:257:5
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
main@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:381:10
@resource://firebug-next-at-getfirebug-dot-com/firebug-next/lib/index.js:23:20
evaluate@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:223:19
load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:257:5
CuddlefishLoader/options<.load@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/loader/cuddlefish.js:129:18
main@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/toolkit/loader.js:381:10
run@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/addon/runner.js:145:19
startup/<@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/addon/runner.js:113:7
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:40
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:40
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:153:9
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:40
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:153:9
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:118:11
then@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:43:43
resolve@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/core/promise.js:185:11
readAsync/<@resource://extensions.modules.firebug-next-at-getfirebug-dot-com.commonjs.path/sdk/net/url.js:49:9
NetUtil_asyncOpen/<.onStopRequest@resource://gre/modules/NetUtil.jsm:123:17

So I don't know what to do to run it... Any suggestion?

Florent

simonlindholm commented 10 years ago

And you're getting these errors on the same firebug.next commit? Hmm. I don't know. Trying an older Firefox version is one idea...

cfx run -o -b ~/firefox-nightly/firefox

(I thought you needed a value for -o, but perhaps not.)

Either way, the way we cause this from the DOM panel, which seems very relevant, is https://github.com/firebug/firebug.next/blob/1d02ca4d22089c52b7ddaa516488e9f9689cd887/lib/dom/domPanel.js#L77. Note the work-around threadClient.resume(); a few lines below, which sometimes works. I wanted to see how the Web Console did this, but got lost in the code.

fflorent commented 10 years ago

And you're getting these errors on the same firebug.next commit?

Yes

Hmm. I don't know. Trying an older Firefox version is one idea...

Already did :(

Florent

fflorent commented 10 years ago

I confirm this works again.

Florent

janodvarko commented 10 years ago

Thanks for verification.

Honza

janodvarko commented 9 years ago

$fixed firebug-3.0.0-alpha.1