Additional Side Panel bug

[aliuk2012]

How to replicate:

1. Go to any website
2. With the "Console" (or any tab that has an "expand" sidebar button) tab open, expand the Command Editor
3. Then click the "Dock to Side of browser window" button
4. An additional sidebar gets created but Firebug console does not move to it
5. If you repeat this enough times the browsers layout starts expanding sideways

I've tried this in both XP SP3 FF 39 & Mac OS FF39/Nightly with exactly the same results. Additionally if you attempt to change the position using the option from the Start button it does the same thing and will not select the right side.

[cdcmicro]

The same is true if FB is detached in its own window and attempt to dock it to the main browser window on Win7 x64 / FF 41.0.2.

It seems to reserve the pane in the target browser window, but never moves there.

[janodvarko]

Should be fixed by the patch above.

@aliuk2012 can you please verify?

Thanks for the report Honza

[darkred]

Sorry, but how can one try the new Firebug version(build) with that patch included? The only way is via jpm xpi ? Or there is Firebug nightly? (like it's with Greasemonkey)

[janodvarko]

The only way is via jpm xpi ?

Yes, this is the right way (we don't have nightly builds)

Honza

[darkred]

Thank you for replying.

So, I followed the instructions (using git 2.6.2 x64 and npm 2.14.7 in win10x64)

git clone https://github.com/mozilla/jpm
npm install   
npm link
git clone https://github.com/firebug/firebug.next
npm install
npm link
jpm xpi

and jpm xpi generated an 670 KB firebug@software.joehewitt.com-3.0.0-beta.1.xpi but installing it in a clean profile of either FF45 Nightly or 41.0.2 stable and it does nothing: no toolbar button, nothing extra in devtools: it's only an entry in about:addons.

[janodvarko]

Can you share your xpi, so I can try it on my machine?

Honza

[darkred]

Yes, of course: https://www.dropbox.com/s/vmm19chwlcnxf4r/firebug%40software.joehewitt.com-3.0.0-beta.1.xpi?dl=0

[janodvarko]

External modules are missing in the XPI, you need to do: npm install in firebug.next directory and generate the xpi again.

Honza

[darkred]

I'm (almost) sure I had done this initially (without getting any errors).

Anyway, here is what I got now:

$ npm install
npm WARN package.json firebug@3.0.0-beta.1 license should be a valid SPDX license expression
npm ERR! Windows_NT 10.0.10240
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7

npm ERR! version not found: addon-httpd@0.0.1
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Kostas\Desktop\New folder\firebug.next\npm-debug.log

Here is the npm-debug.log: https://www.dropbox.com/s/nzrzbecxo80vz8l/npm-debug.log?dl=0

(I have even cloned, installed and linked addon-sdk)

[janodvarko]

Looks like the license needs to be updated. If you go to package.json (root dir) and change the licence field to: BSD-3-Clause ... does it help?

Honza

[darkred]

The npm WARN entry doesn't show up anymore, but the rest errors are the same:

$ npm install
npm ERR! Windows_NT 10.0.10240
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7

npm ERR! version not found: addon-httpd@0.0.1
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\Kostas\Desktop\New folder\firebug.next\npm-debug.log

[janodvarko]

I've fixed the problem. (the license is also fixed)

Please update from firebug.next repo, try again and let me know :-)

Honza

[darkred]

Yes, now it's build ok, and I confirm that the 'additional Side Panel' bug is fixed. Thanks. Just one thing, please: does it matter (in building the xpi) if I upgrade node.js to 5.0.0 (from 4.2.1), i.e. upgrade npm 3.3.6 (from 2.14.7)? Or, should I stay in 4.2.1?

[janodvarko]

Yes, now it's build ok, and I confirm that the 'additional Side Panel' bug is fixed. Thanks.

lol, thanks for the verification!

Just one thing, please: does it matter (in building the xpi) if I upgrade node.js to 5.0.0 (from 4.2.1), i.e. upgrade npm 3.3.6 (from 2.14.7)? Or, should I stay in 4.2.1?

I think you can upgrade, it should work (but I didn't test it) If not, please file a new issue and I'll fix it :-)

Honza

[darkred]

Alright. I just upgraded and was built ok. Thanks again

[janodvarko]

Excellent, thanks for the update.