firebug / firebug.next

Next Firebug generation built on top of native Firefox developer tools
Other
229 stars 37 forks source link

Make Animations side panel layout fit more to Firebug #424

Open SebastianZ opened 8 years ago

SebastianZ commented 8 years ago

The timeline within the Animations side panel looks a bit ugly and doesn't really fit to the general Firebug layout.

*Animations* side panel not looking *firebuggy*

Tasks:

Sebastian

compojoom commented 8 years ago

@janodvarko would you please advise me how to fix this? I have followed the developer guide and now I'm running Firefox with firebug from git. I saw that you've addressed some of the problems in this issue ff-animations fb-animations

But it's actually not fully fixed. When we hover with the mouse over the pause button in near the timeline - the hover state is invisible.

Also as you can see from the ff-animations screenshot -> the inspector tools is showing a rewind icon. With the browser tools I saw that the markup is there. markup

Some of the buttons are falling behind the progressbar and also we don't have any images for those. What are the guidelines here? Where are we taking the images from?

SebastianZ commented 8 years ago

You're obviously using the wrong version of Firefox. Ensure that you're running Nightly. Then the Animations side panel should look like this:

*Animations* side panel

To do that you need to define the Firefox binary via the -b parameter when you call jpm.

Sebastian

compojoom commented 8 years ago

@SebastianZ - aaaah. okay! Thanks!

So, it seems that this issue is actually fixed?

SebastianZ commented 8 years ago

So, it seems that this issue is actually fixed?

No, as mentioned above the current style doesn't fit to the general Firebug layout. E.g. Firebug doesn't have striped bars anywhere. So the tasks listed in the first post are still valid.

Sebastian

fflorent commented 8 years ago

@compojoom Hello. Thanks for being interested in this issue!

Do you need some help / information of any form?

Florent