search

firebug / firebug.next

Next Firebug generation built on top of native Firefox developer tools
Other
229 stars 37 forks source link

Hide second filter field in Console panel #433

Closed SebastianZ closed 8 years ago

SebastianZ commented 8 years ago

The Filter output field from the DevTools within the Console panel should be hidden when the Firebug theme is enabled.

Second filter field in *Console* panel

Sebastian

fflorent commented 8 years ago

I take that little one.

Florent

fflorent commented 8 years ago

@janodvarko I just removed a rule. I am not sure about the reason of this comment:

/* But, make the field visible in the Browser console */

Even in the Browser console, it would be redundant, right?

Florent

fflorent commented 8 years ago

BTW, thanks for the report Sebastian ;)

janodvarko commented 8 years ago

I just removed a rule. I am not sure about the reason of this comment:

The rule must be there, but fixed.

The filter should be visible in the Browser Console (since there is no tab bar with the shared input field) and hidden is standard Console panel (since the Toolbox has the shared input field if Firebug theme is active).

Honza

fflorent commented 8 years ago

Ah, right, I get now what is the Browser Console.

I don't see any way to differentiate it from the "regular" Console panel in the DevTools. I report an issue and submit some patch.

Florent

fflorent commented 8 years ago

Reported here. I'll take a look later: https://bugzilla.mozilla.org/show_bug.cgi?id=1221770

Florent

janodvarko commented 8 years ago

@fflorent I made a comment in that report.

Honza

janodvarko commented 8 years ago

@fflorent I forgot to ask about this on today's meeting...

Any progress, should I help?

Honza

fflorent commented 8 years ago

I'll work on this today

Florent

fflorent commented 8 years ago

I changed the code to follow your suggestion.

I slightly adapted it : I supposed it would be more interesting to have the panel attribute global to each toolbox panels, so it would be reusable. What do you think?

Florent

janodvarko commented 8 years ago

OK, works for me, you can merge into the master, thanks! Honza

janodvarko commented 8 years ago

@fflorent: I think you can close the platform bug,

Honza

fflorent commented 8 years ago

Yep !

SebastianZ commented 8 years ago

LGTM. Thank you, Florent!

Sebastian

fflorent commented 8 years ago

Thanks for the feedback Sebastian!

Florent