Closed fflorent closed 8 years ago
@janodvarko Patch above. Could you please review.
Also I wonder why the "type": "search"
attribute has been commented ?
Florent
Updated so we support Nightly (not much related, though).
Edit: the above commit would also fix #442
Florent
Also I wonder why the "type": "search" attribute has been commented ?
I don't remember, but your changes seem to be correct.
The match is not made automatically unless the user presses enter
I don't understand this comment, this doesn't happens even if Firebug theme is not activated
Otherwise it works for me, you can merge!
Honza
I don't understand this comment, this doesn't happens even if Firebug theme is not activated
I do see that feature (automatic completion as the user types) when the theme is not applied. It used not to be present when the FB theme was not activated. Anyway, that's fixed with the type: "search"
property.
Florent
@janodvarko I have merged. It conflicted with this commit: https://github.com/firebug/firebug.next/commit/65bc23f1cdf85ef841c0668fecfacfdb11352d70#diff-47fdb22747526f630f4a20d50d352a7fR165
I took my version of the patch as it works with Nightly. Feel free to adapt it as you would like.
Florent
@fflorent looks good to me.
Honza
Two native features are missing in the search box of the inspector panel:
STR:
Florent