firebug / firebug.next

Next Firebug generation built on top of native Firefox developer tools
Other
229 stars 37 forks source link

Side panel display within Inspector panel broken #442

Closed SebastianZ closed 8 years ago

SebastianZ commented 8 years ago

The side panels within the Inspector panel can't be displayed. I.e. the side panel toggle button doesn't do anything and the separator can't be dragged to show the side panels.

*Inspector* side panels not shown

In the Browser Console I see the following error (didn't check if it's related, though):

TypeError: parentNode is null
Stack trace:
XulTag.prototype.build@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firebug-at-software-dot-joehewitt-dot-com/lib/core/xul.js:61:9
FirebugToolboxOverlay<.customizePanelTabs@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firebug-at-software-dot-joehewitt-dot-com/lib/chrome/firebug-toolbox-overlay.js:213:24
FirebugToolboxOverlay<.onApplyTheme@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firebug-at-software-dot-joehewitt-dot-com/lib/chrome/firebug-toolbox-overlay.js:159:5
emitOnObject@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:112:9
emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js:89:38
Theme.onThemeApply@resource://gre/modules/commonjs/toolkit/loader.js -> resource://firebug-at-software-dot-joehewitt-dot-com/lib/chrome/theme.js:150:3
switchTheme@chrome://devtools/content/shared/theme-switching.js:90:7
@chrome://devtools/content/shared/theme-switching.js:124:1
@chrome://devtools/content/shared/theme-switching.js:5:2
 core.js:106

Sebastian

fflorent commented 8 years ago

Sounds like it will be fixed in issue #438 (with this commit: https://github.com/firebug/firebug.next/commit/7d57355e31e87cd7f4e9e8365807369bb4bbf1c3). If I rebase the branch issue438 with master, so problem is gone (though the search box is missing due to #441 :))

Florent

fflorent commented 8 years ago

@SebastianZ Does it work now? I merged the fix in master

Thanks in advance !

Florent

SebastianZ commented 8 years ago

Yes, they are displayed again. Merci beaucoup, Florent! :-)

Sebastian

fflorent commented 8 years ago

Bitte schön Sebastian. Thanks the reportFlorentfirebug/firebug.next a écrit :Yes, they are displayed again. Merci beaucoup, Florent! :-)

Sebastian

—Reply to this email directly or view it on GitHub.