Toggle button for Style Editor side panels doesn't work

[SebastianZ]

The side panel toggle button doesn't work within the Style Editor panel.

Sebastian

[janodvarko]

Fixed by https://github.com/firebug/firebug.sdk/commit/8b148af714e18623f9e47230e3d7707f5e971b89

You need git pull from firebug.sdk repo.

Honza

[darkred]

You need git pull from firebug.sdk repo.

Sorry to bother you, but what do you mean? How to do the git pull?

What I have done so far:

Initially

git clone https://github.com/mozilla/jpm
cd jpm
npm install 
npm link
cd ..
git clone https://github.com/firebug/firebug.next
cd firebug.next
npm install

Today: (based on your instructions from here)

cd firebug.next
npm update
jpm xpi

but after installing the produced xpi, the mentioned issue remains.

I also tried today:

cd ..
git clone https://github.com/firebug/firebug.sdk
cd firebug.sdk
npm install
cd ../firebug.next
npm update
jpm xpi

but the issue still remains with the produced xpi.

[janodvarko]

Yeah, it's because I am not publishing Firebug.sdk after every commit. I am rather having linked the firebug.sdk directory using: npm link (just like you did for jpm above).

So, git pull origin master from firebug.sdk directory is actually enough

@darkred Does that make sense?

Honza

[darkred]

@janodvarko Yes, of course. So, I did a git pull origin master (and npm link ) in firebug.sdk directory. But, after installing the generated xpi (via git pull,npm update,jpm xpi in firebug.next directory) the mentioned issue still remains, i.e. the toggle button still doesn't work. Could you please take a look? https://www.dropbox.com/s/vmm19chwlcnxf4r/firebug%40software.joehewitt.com-3.0.0-beta.1.xpi?dl=0 (804 KB)

[janodvarko]

@darkred Package linking is two steps process.

1) npm link // in firebug.sdk 2) npm link firebug.sdk // in firebug.next

See more: https://docs.npmjs.com/cli/link

To make sure that you setup that correctly check out the node_modules/frebug.sdk (in firebug.next dir) it should be slink not a dir.

Does it help?

Honza

[darkred]

Yes, by unlinking+uninstalling both (and removing the directories), and then first npm cache clean and then installing them again, and it's ok now. Thanks a lot for your help, once more! I really appreciate it.

---

And something more:

I use Firefox nighly/inbounds exclusively, and as a javascript hobbyist it's great been able to watch the development of (and use) firebug.next each day, and contribute to it if I can. (But, this was the first time for me to build an xpi, i.e. trying with git,npm,jpm,etc. That's why I needed help a few times to clarify things).

So I'd like to make this suggestion, please: to update the info on how to build firebug.next (in both the project's main page and the wiki ) with the above info - especially about the installation of firebug.sdk that's required -. It would be very useful for anyone (like myself) who wants to build the latest xpi, each day, without having to bother you, asking for help.

[janodvarko]

and it's ok now. Thanks a lot for your help, once more! I really appreciate it.

Excellent!

firebug.next each day, and contribute to it if I can. Sounds great!

So I'd like to make this suggestion, please:

Good point I'll do it.

Honza

[darkred]

Good point I'll do it.

Thank you.

Also, I just installed Firebug 3 beta 2 in Nightly 45.0a1 x64 2015-11-20 in win10 x64(even on a clean profile), and unfortunately the Media Rules toggle button is not working.

Also, another thing I noticed is that, the latest xpi I built via jpm xpi was 1034 KB while, the one for beta 2 is 801 KB. Why is that? Is this expected?

[SebastianZ]

Just for confirmation, it's also working for me now. Thank you, Honza!

Sebastian

[darkred]

@SebastianZ commented on Nov 23, 2015, 1:42 PM GMT+2:

Just for confirmation, it's also working for me now. Thank you, Honza!

Sebastian

I just tried installing it once more in Nightly 45.0a1 x64 2015-11-22 (win 10 x64) in a clean profile (with e10s enabled), and the toggle button is not working!

Also, the button doesn't work after either rightclicking on the tab and pressing "Open in a new non-e10s window" or after disabling e10s via Options|General|untick "Enable multiprocess Nightly" (and restart).

[SebastianZ]

I just tried installing it once more in Nightly 45.0a1 x64 2015-11-22 (win 10 x64) in a clean profile (with e10s enabled), and the toggle button is not working!

Right, it just works when running jpm run or building my own XPI. The changes done in this issue are not included in Firebug 3 beta 2. Honza, why that?

Sebastian

[darkred]

@janodvarko A comment on this, please?

[janodvarko]

Ah, both should be fixed now: https://github.com/firebug/firebug.next/releases/tag/firebug-3.0.0-beta.3

• The Firebug.sdk module wasn't updated. I forgot npm pull when doing the release :-)
• The xpi size is smaller (only firebug.sdk is included now)

Honza

[darkred]

Thank you