search

firebug / firebug.next

Next Firebug generation built on top of native Firefox developer tools
Other
229 stars 37 forks source link

Implemented "Events TAB" of the old firebug (Cant commit, can you port it to the new branch?) #474

Open TheLaGmAn opened 8 years ago

TheLaGmAn commented 8 years ago

I have implemented the old firebug2 events tab in firebug3.

It also shows the delegated events from jQuery which the current devtools and firebug3 do not show (it was a missing feature), now its there.

@janodvarko @fflorent

I cant push a commit here, seems like this branch is closed, can you port it to the new devtools with the integrated firebug? Files are attached, just 3 (2 new, 1 modified)

Image

/lib/inspector/events-list.js /lib/inspector/inspector-overlay.js /lib/data/events-list/events-list.html

The code might not be up to the current standards but it works perfectly well, i also had to do a combination of the jQuery data events and the native frontNode events because the frontNode ones do not provide the "selector" information to match delegated events, this is something that would probably need to be requested to add in the firefox devtools.

fflorent commented 8 years ago

Thanks for the patch. As you may probably already know, the Firebug theme has been integrated into the DevTools and the features in Firebug 3 too (like the DOM panel).

So could you please consider submitting your patch to the DevTools here: https://bugzilla.mozilla.org/show_bug.cgi?id=1226640

Also I think the DevTools support jQuery events. You may be interested in taking a look in their implementations. Don't hesitate to get in touch with pbro on IRC (#devtools on irc.mozilla.org) or through the bug.

Cheers, Florent

TheLaGmAn commented 8 years ago

Thanks, i posted there to see if they could be able to port it over since i havent touched anything on the devtools yet it might take me an awful amount of time to get my hands on that comparing to someone already developing there that could port it easily.

fflorent commented 8 years ago

Don't hesitate to ask for help on IRC (if you know how it works), they help with pleasure.

Florent