search

firebug / firebug

Web Development Evolved - The Firebug you have known and loved
http://getfirebug.com/
1.35k stars 341 forks source link

Make all Break On ... features available within the Script panel #2701

Open fbugissues opened 9 years ago

fbugissues commented 9 years ago

Originally reported on Google Code with ID 2562

in recent 1.5b5 and 1.5b6, i'm missing the break on errors functionality in
the script tab.

it always used to be in the options of the script tab, but it isn't:
http://www.siebert-wd.de/system/skitch/break_on_errors_missing-20091208-185645.jpg

browser if ff 3.5.4 and ff 3.6b4, both on mac osx 10.6

Reported by siebertm85 on 2009-12-08 17:58:06

fbugissues commented 9 years ago 
Please see:
http://getfirebug.com/doc/breakpoints/demo.html#errors

Reported by johnjbarton@johnjbarton.com on 2009-12-08 22:50:39

fbugissues commented 9 years ago 
oh, i'm really sorry for that! it works, BUT the icon is a "break on next statement"
icon, which is why i didn't even consider this as what i want. 

considering the fact that i work with fbug on a daily basis, i think keeping this
icon would generate a lot of traffic "in production" (just as my post did)

so the real icon should be a pause icon mixed with an error icon... i'll have to say,
the internet explorer 8 debugger break on error icon does this very well.

is this a new ticket or should we keep it in here?

Reported by siebertm85 on 2009-12-09 08:25:44

fbugissues commented 9 years ago 
other than that, i just saw that, when i'm in the console panel, the "pause" icon is
"break on all errors", but when i'm in the script panel, the same icon is "break on
next"!

this kinda... sucks.

i mean, the firebug icon and the inspect dom icon have the same functionality in all
panels. why should the pause icon which visually belongs to the same group of icons
change its meaning when i change panels? 
if the pause icon would be below the tabs, it would "belong" to the tab i'm currently
on, but when it's above the tabs, it should be a global thing, not changing it's
functionality depending on where i'm in.

Reported by siebertm85 on 2009-12-09 08:37:59

fbugissues commented 9 years ago 
I think the idea of changing the icon for the different panels is a good idea. It
would help users see that there is new functionality.

Reported by sabine.michael.ratcliffe on 2009-12-09 09:46:00

fbugissues commented 9 years ago

Reported by johnjbarton@johnjbarton.com on 2010-01-05 19:08:52

fbugissues commented 9 years ago 
Moving the "Break on..." button was already done in Firebug 1.5.1 (see issue 2837).
Though it would be good to have this button again, because the usability of this
feature now changed and you have to jump between console and script panel to use the
"Break on error" feature. To implement this you could either create a "Break on..."
menu button or create a seperate "Break on error" button. For both I attached a
screenshot how this could look like.

Reported by sebastianzartner@gmx.de on 2010-04-07 10:12:08

fbugissues commented 9 years ago 
plus one for that.

Reported by siebertm85 on 2010-04-07 10:15:05

fbugissues commented 9 years ago 
An advantage of using a dropdown for this is that more users would learn about the
different break on x possibilities.

Reported by sabine.michael.ratcliffe on 2010-04-07 11:41:43

fbugissues commented 9 years ago 
For a test case use the one of issue 3134.
1. Enable and switch to the Script Panel
2. Click the "Break On All Errors" button (not existing at the moment)
3. Click the "Throw error" button inside the page

=> Same behavior as "Break On All Errors" in Console Panel

Script Panel should have "Break On All Errors" again

Reported by sebastianzartner@gmx.de on 2010-07-21 09:58:41

fbugissues commented 9 years ago 
I think this feature could be made more general:
Every panel having a Break On ... button should also add that option to the "Break
On ... Menu" inside the Script panel.

Also I believe this is something we should add in Firebug 1.11.

Sebastian

Reported by sebastianzartner on 2012-06-25 07:29:17

fbugissues commented 9 years ago 
I don't understand this:

> Same behavior as "Break On All Errors" in Console Panel
(from comment #9)

The scrip panel implements "Break on Next" not "Break on Error"
So, if you click on "Throw Error" the debugger breaks on line 55 since it's the first
(next) JS executed. It also breaks if you click on the other buttons

The Console panel breaks only on errors.

Test case:
https://getfirebug.com/tests/manual/issues/2995/firebug_2995.htm

---

> Every panel having a Break On ... button should also add that option
> to the "Break On ... Menu" inside the Script panel.
I like this so, is it the only problem to fix here?

Honza

Reported by odvarko on 2012-10-24 11:47:35

fbugissues commented 9 years ago 
> The scrip panel implements "Break on Next" not "Break on Error"
> So, if you click on "Throw Error" the debugger breaks on line 55 since it's the 
> first (next) JS executed. It also breaks if you click on the other buttons
Up to Firebug 1.4 the Script panel also had the option "Break On All Errors" inside
its options menu.

>> Every panel having a Break On ... button should also add that option
>> to the "Break On ... Menu" inside the Script panel.
> I like this so, is it the only problem to fix here?
Yes. Just to be clear: The Break On... button of the Script panel should be a split
button. Opening the split menu offers "Break On All Errors", "Break On Mutate", "Break
On XHR", "Break On Cookie Change" and whatever will come in the future. It should at
least list these options as text, though the icon besides each entry would be more
declarative.

Sebastian

Reported by sebastianzartner on 2012-10-24 12:55:12

fbugissues commented 9 years ago 
> Just to be clear: The Break On... button of the Script panel
> should be a split button.
Hm... I thought it would be part of the Script panel's options menu.
(where we also have visible labels btw)

This way the 'Break on' button looks/behaves the same in all panels, which I think
is more consistent.

Is this ok for you?

Honza

Reported by odvarko on 2012-10-25 06:43:51

fbugissues commented 9 years ago 
I don't really like having the other Break On ... options inside the options menu. Doing
so we'd have the Break On ... features split over different places, which is inconsistent
with the UI.

To illustrate what I was talking about I created an updated mockup.
I imagined the button to work like the split button inside the CSS panel. So selecting
another option makes that one the default. Clicking the button would arm the selected
Break On ... feature.

The menu would work like the Panel Selector Menu, i.e. clicking the text would make
the Break On ... feature the default while clicking its icon arms it. Doing so you
can arm several Break On ... features at the same time. Though this split functionality
could be added in a later step.

If the icons are too cluttering, they could be replaced by checks.

Sebastian

Reported by sebastianzartner on 2012-10-25 07:48:17

fbugissues commented 9 years ago 
So, this is really quite complex.

Agree, not a blocker.

Honza

Reported by odvarko on 2012-10-25 10:32:45

fbugissues commented 9 years ago

Reported by sebastianzartner on 2013-10-21 12:02:26

fbugissues commented 9 years ago

Reported by sebastianzartner on 2014-01-22 15:43:37

fbugissues commented 9 years ago

Reported by sebastianzartner on 2014-04-16 11:34:10

fbugissues commented 9 years ago

Reported by sebastianzartner on 2014-04-26 00:18:01