firebug / netexport

Firebug extension - export data from the Net panel

http://www.softwareishard.com/blog/netexport/

Other

35 stars 17 forks source link

Issue 5971: programmatic triggering of NetExport #2

Closed vincentbernat closed 10 years ago

vincentbernat commented 11 years ago

An export can be triggered with window.NetExport.triggerExport("token")(). Automatic export has to be enabled for this function to be available. However, it is possible to disable unattended automatic export by setting the timeout to 0.

Since we don't want any page to trigger an export, token is a security token that should be kept secret and is set by the user in extensions.firebug.netexport.secretToken. If the token is incorrect, it is not possible to call the final function.

It should be easy to add other functions like this. I have tried to be secure in how the function is exported. Keep in mind I am not familiar with extensions.

simonlindholm commented 11 years ago

The coding style is a bit off, I'd personally prefer window.NetExport.triggerExport("token") as syntax, and see the nit above. Otherwise it basically looks good to me.

@janodvarko: will you get to this at some point?

janodvarko commented 11 years ago

@janodvarko: will you get to this at some point?

Yeah, I want to, but not sure when. If you have time I can assist.

Honza

vincentbernat commented 11 years ago

I have fixed the problem about the scope of f. I will now modify the way the export function is called.

vincentbernat commented 11 years ago

@simonlindholm I have added a patch to use your syntax instead.

vincentbernat commented 10 years ago

@janodvarko Unfortunately, I currently don't have time to amend and test the patch. But I agree with your remarks.

janodvarko commented 10 years ago

Should I go ahead, fix your changes and commit?

Honza

vincentbernat commented 10 years ago

Yes, if you can, please.

janodvarko commented 10 years ago

Patch committed and included in netExport-0.9b5, see more details: https://code.google.com/p/fbug/issues/detail?id=5971#c32

Thanks for the help! Let me know if you agree to put your name into Net Export about dialog :-)

Honza

vincentbernat commented 10 years ago

❦ 7 mai 2014 07:33 -0700, Jan Odvarko notifications@github.com :

Let me know if you agree to put your name into Net Export about dialog :-)

Yeah, of course! ;-)

Okay, what on Earth is this one supposed to be used for?

    2.4.0 linux/drivers/char/cp437.uni

janodvarko commented 10 years ago

Done at: https://github.com/firebug/netexport/commit/a436fa133549ca4bccbe201e00602b72bd838944 Will be in 0.9b6

:-)

Honza