firefox crashes on refresh with pixel perfect turned on

firebug / pixel-perfect

Other

55 stars 15 forks source link

firefox crashes on refresh with pixel perfect turned on #61

Closed sviplab closed 9 years ago

sviplab commented 9 years ago

If browser page is refreshed at the time of pixel perfect turned on then it crashes the browser, i don't think it is the issue of browser. Because of pixel perfect, it is crashing.

Viplab

janodvarko commented 9 years ago

What browser version do you use?

Honza

fflorent commented 9 years ago

Hi,

We would need more information to investigate:

What version of Firefox do you use? And have you got the latest (final 2.0.2) version of Pixel Perfect?
When Firefox crashes, a window appears asking you if you want to send a crash report (as explained here). Have you reported it?

Florent

sviplab commented 9 years ago

I am using the firefox 36.0.4 and pixel perfect 2.0.2

fflorent commented 9 years ago

Oh, thanks for the report. I could reproduce that. Here are the crash reports: https://crash-stats.mozilla.com/report/index/bp-c112bf23-8e8f-4755-bac3-2afc52150330 https://crash-stats.mozilla.com/report/index/bp-d27c8cb4-b23f-4bc7-a847-b4e7f2150330

Florent

fflorent commented 9 years ago

Also reproduced with Firefox 37.

Florent

janodvarko commented 9 years ago

What about Firefox 38?

Honza

fflorent commented 9 years ago

It works fine. Probably worth to bisect that.

Florent

janodvarko commented 9 years ago

Yes please!

Honza

fflorent commented 9 years ago

Sorry, the ftp.mozilla.org site is tonight terribly slow. Here is the command with the current regression window:

mozregression --good=2015-01-22 --bad=2015-01-12 --app=firefox --find-fix --addon=pixelperfectplugin@openhouseconcepts.com-2.0.2.xpi  --bits=64

BTW, Honza, can you reproduce it too?

Florent

janodvarko commented 9 years ago

Yep I can also reproduce that. Here is my crash report https://crash-stats.mozilla.com/report/index/2265eda4-75c2-43be-b2a9-0f9b32150331

Honza

janodvarko commented 9 years ago

@fflorent: does my patch solve the problem for you? (please let me know asap, I'd like to update AMO)

Honza

janodvarko commented 9 years ago

Here is an online version for testing http://softwareishard.com/temp/pixel-perfect/pixelperfect-2.0.3.xpi

There will be a post on hacks.mozilla later today, so I am already trying to pass review on AMO.

Honza

fflorent commented 9 years ago

Works for me now. @sviplab does it for you?

Florent

janodvarko commented 9 years ago

Thanks Florent for quick response!

Honza

sviplab commented 9 years ago

Yeah it works for me too. Thank You @janodvarko and @fflorent

Viplab

fflorent commented 9 years ago

Thanks you for the report and for the feedback :).

Florent

janodvarko commented 9 years ago

Awesome, new version 2.0.3 (with the patch included) already uploaded and approved on AMO https://addons.mozilla.org/cs/firefox/addon/pixel-perfect/

Honza

janodvarko commented 9 years ago

Honza