search

firebug / pixel-perfect

Other
55 stars 15 forks source link

firebug.sdk version dependency is hardcoded #65

Open aliuk2012 opened 9 years ago

aliuk2012 commented 9 years ago

Allow npm install to ignore minor version of firebug.sdk but respect major versions

cadorn commented 9 years ago

I have been using the x variant to slip the patch version as it seems to work most reliably when updating the installed dep to a new patch version:

"dependencies": {
    "firebug.sdk": "0.5.x"
}
cadorn commented 9 years ago

You can also do 0.x but I usually keep the minor version until a lib reaches at least 1.0.

fflorent commented 9 years ago

It is not really a big deal to have a version hardcoded. It is even IMHO a good practice : it means the code has been tested with the specified version of the dependency (and avoid regressions because of an update of it).

If an update of it is available, that's the work of the maintainer to update the package.json file and test again their work.

Just my two cents.

Florent

cadorn commented 9 years ago

I essentially agree. I will have a tool to alert us and auto-test new versions for each extension.

aliuk2012 commented 9 years ago

@fflorent I would normally agree but as we get more extensions it will get harder to maintain. I like @cadorn idea of having a tool alert us and then for it to rerun the tests.

Ok, should we leave the minor version in for the time being and just relax the patch version?

aliuk2012 commented 9 years ago

Actually this repo is a good example, firebug.sdk is already on 0.5.8 where pixel perfect is looking for and trying to use 0.5.5