search

firebug / websocket-monitor

Not compatible with Firefox Quantum (57 and newer)
Other
147 stars 18 forks source link

Fix encoding issues, closes #39, closes #43 #44

Closed lebedev closed 8 years ago

lebedev commented 8 years ago

Hi there! I've managed to fix encoding issues. My steps of this issue investigation:

  1. Using online decoders, I've tried to decode messed up payload and learned that for whatever reason frame's payload was in ISO-8859-1 encoding.
  2. I've found the way to convert ISO-8859-1 to UTF-8 in here on StackOverflow, using "the other way round".
  3. I added the corresponding reencoding code to frameReceived and frameSend, the only 2 places where a frame gets JSON.parsed.

Look at the results (using your WebSockets test page): With turkish symbols:

With cyrillic symbols:

This should close issues #39, #43.

janodvarko commented 8 years ago

Thanks!

Honza