Falsy JSON values appear as quoted empty strings

firebug / websocket-monitor

Not compatible with Firefox Quantum (57 and newer)

Other

147 stars 18 forks source link

Falsy JSON values appear as quoted empty strings #68

Open tdhsmith opened 7 years ago

tdhsmith commented 7 years ago

Expanding JSON payloads or inspecting them in the JSON tab seems to wreck JS falsy values (notably 0 and null) and display them as quoted empty strings ("").

For example, observe how the objectId and alert properties change as the tree is expanded: screen shot 2017-01-05 at 2 10 40 pm Demonstrated in WebSocket Monitor 0.6.4 on FF dev edition 52.0a2.

Is all the TreeView behavior coming from the Firebug SDK? I don't know enough about extensions or React to trace the functionality very quickly here...

eliihen commented 7 years ago

Hey, good catch. I can reproduce on http://janodvarko.cz/test/websockets/ by sending {"a":0}

Yep, the TreeView behavior is from the Firebug SDK, so you should open a bug over there. When it is fixed in the SDK we can bump the version of the version in Websocket Monitor

eliihen commented 7 years ago

Wait. It turns out this was fixed a while ago https://github.com/firebug/firebug.sdk/pull/20, but no new version was released! I'll make an issue to see if we can get it bumped

tdhsmith commented 7 years ago

Awesome thanks for the fast response!