firecamp-dev / firecamp

Developer-first OpenSource API DevTool, Postman/Insomnia alternative.
https://firecamp.dev
GNU Affero General Public License v3.0
2.1k stars 137 forks source link

feat: HAR <> Firecamp request converter #129

Closed jatingodnani closed 1 year ago

jatingodnani commented 1 year ago

115

hey @Nishchit14,I added code, can you tell me if what I'm doing is correct .you can tell me hat i am doing wrong

netlify[bot] commented 1 year ago

Deploy request for staging-firecamp-dev pending review.

Visit the deploys page to approve it

Name Link
Latest commit f7be9ccac7324668e6411b3ba92b23e5df92e04d
CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: jatingodnani
:x: jatin


jatin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

jatingodnani commented 1 year ago

@Nishchit14 already sign cla license then why it showing incorrect

Nishchit14 commented 1 year ago

follow this steps

  1. sign cla (your commit username is different than your GitHub username, please read the description given by the cla bot)
  2. follow camelcase naming conventions, check all spelling related comments by spell bot
  3. set up tests with expected behavior, following the TDD approach here. (you can search on the web HAR to X GitHub repo to find some references.)
Nishchit14 commented 1 year ago

@jatingodnani

image
jatingodnani commented 1 year ago

@Nishchit14 i will if completed,i am asking you to check my approch because i havent make any converter