Firecamp Desktop App

[Nishchit14]

62

[netlify[bot]]

✅ Deploy Preview for staging-firecamp-dev ready!

Name	Link
🔨 Latest commit	ae5f7b4e6146ebea86fbe4730fd8e07638c32040
🔍 Latest deploy log	https://app.netlify.com/sites/staging-firecamp-dev/deploys/65e5c0d2f742aa000893b023
😎 Deploy Preview	https://deploy-preview-164--staging-firecamp-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[LukeHagar]

Hey @Nishchit14,

I was going to attempt to fork the repo and help with some things like the spelling errors GitHub advanced security flagged on, but I'm getting this error trying to switch to this branch.

If I can help with Electron at all I would be happy to, and good luck with the Desktop release!

[Nishchit14]

@LukeHagar Thanks for forking the repo, First you can run the app in web mode with pnpm dev command. You can contribute whatever you wish there. If anything specific to the desktop app, you can consider pakcages/firecamp-electron directory to navigate. just run pnpm start to open the local desktop app.

[Nishchit14]

@jsoref Can you please help here why the job is failing?

[jsoref]

@Nishchit14: so, there are a few things here, one is to change Typescript to TypeScript

The second is that b000709b6525c4a55ed30e48f36625a027bbf82f introduced an empty log file https://github.com/firecamp-dev/firecamp/blob/b000709b6525c4a55ed30e48f36625a027bbf82f/packages/firecamp-desktop/src-tauri/rustc-ice-2023-08-29T12:21:32.539513Z-24344.txt and 3a030cc052e076840445e4aeeba2e462fa445976 introduced an empty log file in https://github.com/firecamp-dev/firecamp/blob/3a030cc052e076840445e4aeeba2e462fa445976/packages/firecamp-desktop/src-tauri/rustc-ice-2023-09-01T10:38:16.464703Z-21654.txt (which were renamed in e0ca14b6).

I don't see anything in the commits that explain why those files should be included in the repository. Personally, I'd be inclined to delete them.

The rest of the items appear normal and can be accepted as is.

[Nishchit14]

Thank you @jsoref for the PR with fixes, Those empty files were generated with Tauri initialisation process.

Also where can I see all these error logs? I tried to debug the failed job but I couldn't find anything helpful

[jsoref]

For a given commit, you can click the ❌ on the right (a similar one at the bottom of a PR would work, but it's now a ✅ , so I can't link there):

And then click Details:

And then click Summary on the left:

Then scroll down to the bottom

---

The first bits are in:

Unrecognized words (4)

APPIMAGE eciesjs rustc togglefullscreen

---

The second set of things were covered in this:

Some files were automatically ignored :see_no_evil:

These sample patterns would exclude them: ``` ^\Qpackages/firecamp-tauri/src-tauri/rustc-ice-2023-08-29T12:21:32.539513Z-24344.txt\E$ ^\Qpackages/firecamp-tauri/src-tauri/rustc-ice-2023-09-01T10:38:16.464703Z-21654.txt\E$ ``` You should consider adding them to: ``` .github/actions/spelling/excludes.txt ``` File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use `patterns.txt` to exclude portions, add items to the dictionary (e.g. by adding them to `allow.txt`), or fix typos.

---

And indication about forbidden patterns is in the Errors section:

Errors (3)

See the [:open_file_folder: files](https://github.com/firecamp-dev/firecamp/pull/164/files/) view, the [:scroll:action log](https://github.com/firecamp-dev/firecamp/actions/runs/8139280566/job/22242094103#step:4:1), [:angel: SARIF report](https://github.com/firecamp-dev/firecamp/security/code-scanning?query=is:open+pr:164), or [:memo: job summary](https://github.com/firecamp-dev/firecamp/actions/runs/8139280566/attempts/1#summary-22242094103) for details. [:x: Errors](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) | Count -|- [:information_source: binary-file](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#binary-file) | 2 [:x: check-file-path](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#check-file-path) | 2 [:x: forbidden-pattern](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions#forbidden-pattern) | 2 See [:x: Event descriptions](https://github.com/check-spelling/check-spelling/wiki/Event-descriptions) for more information.

---

The specific details of everything are in:

Details :mag_right:

...

[Nishchit14]

Thank you @jsoref for your all help 🙌