search

firecamp-dev / firecamp

Developer-first OpenSource API DevTool, Postman/Insomnia alternative.
https://firecamp.dev
GNU Affero General Public License v3.0
2.1k stars 137 forks source link

Feat: The windows App lacks a title bar improvement #186

Open Nishchit14 opened 8 months ago

Nishchit14 commented 8 months ago

The windows build lacks a title bar.
Thus, you cannot move, resize, minimize, etc. the window.

Originally posted by @Alia5 in https://github.com/firecamp-dev/firecamp/discussions/167#discussioncomment-8547378

Alia5 commented 8 months ago

I'd be happy to help out by opening a PR.

However, I don't think I have enough of an overview yet.

The quick-fix would be to set the frame property to true when calling new BrowserWindow(...)
Is this an acceptable fix for the time being, if restricted to Windows?
Or is it an issue on other platforms as well?

Should there even be a native Window-Frame shown, or is there a custom title-bar implemented that is simply now shown?

Should a custom title-bar be implemented if not already present? If so how would the platform specific look like?

teckdev commented 7 months ago

Same issue is happening on Mac with M processor.

Nishchit14 commented 7 months ago

@Alia5 I agree with your thought, I'll fix it by this weekend. It'll be available in the next release.

MypowerHD commented 3 months ago

Hey @Nishchit14, still present.