search

firecamp-io / firecamp

VSCode for APIs, Postman Alternative.
https://firecamp.dev
317 stars 22 forks source link

Variable is not sent #139

Open pavelsaman opened 3 years ago

pavelsaman commented 3 years ago

Describe the bug

For the following query, variable is not sent, therefore the default argument value is used, which returns much more results than I want.

To Reproduce Steps to reproduce the behavior:

  1. Issue a GraphQL request with Ctrl + Enter shortcut to https://demagog.cz/graphql: 
    query FilterSpeakers($limit: Int) {
speakers(limit: $limit) {
id
}
}

    and variables:

    {
"limit": 7
}
  2. See that limit variable was not sent: image

I've tried with different clients like GraphiQL: image

or Altair: image

If I use the refresh button, or Send button, it seems the variable is set and send correctly, it just doesn't work with Ctrl + Enter. I initially didn't notice this, but now I do. I still consider it a bug, but perhaps there's some logic behind it that only I'm not aware of. However, I use shortcuts often, so I'd vote for the same behaviour even then I press Ctrl + Enter to send a request.

Expected behavior

Setting and sending defined variables with correct values.

Platform:

Nishchit14 commented 2 years ago

it seems like this issue has been resolved already or happening in the special cases as we've passed many releases then after. I am unable to reproduce the same with the latest version v2.2.1

pranavwani commented 2 years ago

@pavelsaman issue fixed and shipped with the earlier version. feel free to reopen if facing again

meenabassem commented 1 year ago

I can confirm the issue exists on

Nishchit14 commented 1 year ago

Thank you @meenabassem for confirming. This issue has been fixed in the chrome extension I guess if you want to try it.

We're about to launch the major version v3, It'll have this fixed soon.

meenabassem commented 1 year ago

Thank you @meenabassem for confirming. This issue has been fixed in the chrome extension I guess if you want to try it.

We're about to launch the major version v3, It'll have this fixed soon.

Great, Thanks for the update, will use the extension for now and wait for the update