search

firecamp-io / firecamp

VSCode for APIs, Postman Alternative.
https://firecamp.dev
317 stars 22 forks source link

Duplicate query string on web socket request #181

Closed freemstr closed 2 years ago

freemstr commented 2 years ago

1. Describe the bug, what it is and what it should be (expected behavior)

When issuing web socket request with Query params, resulting query string is duplicated

?client_id=1?client_id=1

2. To Reproduce

Steps to reproduce the behavior:

  1. go to connections
  2. edit connection to add query params: client_id = 1
  3. URL is updated with ?client_id=1
  4. return to messages and send a message

On the server query string is not valid: "?client_id=1?client_id=1"

3. screenshots/gif/video?

image

4. additional context

I reinstalled Firecamp and installed Canary, neither works as expected

platform (please complete the following information):
welcome[bot] commented 2 years ago

Welcome to the Firecamp! Thanks and congrats for opening your very first issue in Firecamp. Join the Discord community here https://discord.gg/8hRaqhK Hope you have a great time here :)

Nishchit14 commented 2 years ago

thanks @freemstr

the issue is fixed and released with v2.2.1

freemstr commented 2 years ago

@Nishchit14 Verified and working Thank you.