firecamp-io / firecamp

VSCode for APIs, Postman Alternative.
https://firecamp.dev
317 stars 22 forks source link

provide more info on invalid names #25

Closed TheNicholasNick closed 4 years ago

TheNicholasNick commented 5 years ago

instead of a red box / red line / pick a valid name

say why can't use pop or other names that aren't allowed...

Nishchit14 commented 5 years ago

@SoreGums Thanks for raising an issue, Can you please share more details?

Is it a Socket or WS Tab? and which input you're facing this issue. A screenshot would help the best here.

TheNicholasNick commented 5 years ago

actually seems there is simply a 4char min for the name.

doesn't matter what i type as long as i get to 4 chars the box turns green

TheNicholasNick commented 5 years ago

2019-09-16 17_28_40-Firecamp

Nishchit14 commented 5 years ago

Yes, here 4 character is the min requirement to give request/module/project name. Do you have any specific requirement or use-case? please share it so we can improve it :) . According to you what limit is good for name input?

TheNicholasNick commented 5 years ago

Not specifically however it's unintuitive to make a red box "your input is invalid" with no reasons... Why is there even time spent on checking how long the name is? Input accepts text, accept text what needs to be checked?

TheNicholasNick commented 5 years ago

More than 0 characters is a good minimum. Cause being blank or a space is hard to display.

Nishchit14 commented 5 years ago

Thank you @SoreGums , We'll consider your suggestion in future release.