add support for keeotp & keepass2 otp fields

firecat53 / keepmenu

Dmenu/Rofi frontend for Keepass databases

GNU General Public License v3.0

204 stars 32 forks source link

add support for keeotp & keepass2 otp fields #125

Closed bdeshi closed 2 years ago

bdeshi commented 2 years ago

closes #117

TODO

[x] support keeotp's key=... style otp field
[x] support keepass2's totp fields
[x] add tests

bdeshi commented 2 years ago

@firecat53 keepmenu currently supports only base32 encoded otp seeds, i'm doing the same here. support for additonal encodings may be better implemented in a different subsequent PR. ditto for hotp support. because keepmenu currently assumes all otps are of the totp type.

bdeshi commented 2 years ago

@firecat53 please review.

firecat53 commented 2 years ago

Sorry about the delay!! Thanks for the work on this, looks good to me. Do you think there's value in adding documentation to what OTP formats are supported into docs/usage.md? If so, perhaps include some of the links to the documentation that you provided in #117?

If you can rebase on top of the totp branch (I updated my email address recently) after any docs are updated, I'll go ahead and merge this.

Thanks again!

bdeshi commented 2 years ago

@firecat53 how does it look now?

firecat53 commented 2 years ago

Awesome, thanks so much!