search

firecat53 / keepmenu

Dmenu/Rofi frontend for Keepass databases
GNU General Public License v3.0
204 stars 32 forks source link

Pinentry command should probably be uppercase #149

Closed otaj closed 1 year ago

otaj commented 1 year ago

Hi, thank you for the library, it is awesome!

However, I was trying to use it, set pinentry to my very simple wrapper of fuzzel for pinentry protocol and "nothing worked" :tm:. Later on I found out, that the culprit is pinentry - while it is not categorically specified that commands set to to pinentry-like program should be uppercase, all documentation seems to showcase them as uppercase, and keepmenu is sending everything lowercase.

I fixed my pinentry wrapper to accept lowercase as well, so it is solved on my end, however I think it might be correct to use uppercase.

I can send a PR with that if you want.

Thanks again for the cool little program.

firecat53 commented 1 year ago

Fixed, thanks! Interesting that it works on some systems with lowercase (like mine).

otaj commented 1 year ago

Thank you very much! I think the "problem" is more my wrapper using fuzzel than regular implementations - I'd think they maybe convert everything to uppercase first, or something like that. Anyways, thank you again!