firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
783 stars 74 forks source link

positioning and size of dmenu #104

Closed Fuseteam closed 2 years ago

Fuseteam commented 2 years ago

someone submitted a patch for dmenu to control both the position ans size of the menu. perhaps a few sane values could be integrated for the case when the user switches to the vertical layout?

firecat53 commented 2 years ago

All dmenu/rofi configuration is done by adding CLI flags to the dmenu_command option in your config file (see the README) or passing them on the command line. I recently removed all theming from this code base to reduce complexity and make it easier to use different menu applications if desired. Closing, but thanks for the interest!

Fuseteam commented 2 years ago

I know that, i was just hoping you'd be interested in making it into an actual menu by default. I wasn't asking to make the sizing/positoning configurable

firecat53 commented 2 years ago

I guess I'm not sure what you are looking for here, as far as making it an "actual menu". The dmenu positioning is all done through CLI flags that each user can set via the config file. I'm guessing most people won't be using that patch, so it's a non-issue anyways. Also, a fair number of people use Rofi, which is also configured through the theme files.

Right now, the only hard-coded configuration for each different launcher (dmenu, Rofi and bemenu) are the flags for the password input. I'd rather not add any other launcher-specific code if it can be avoided.

Fuseteam commented 2 years ago

the vertical layout is currently a screenwide dropdown with a sane height. with an "actual" menu i mean similar to those indicator menus in DEs. honestly if you're not interested in supporting this as a feature that's fine too i guess

but i'm not interested in rofi and i'm not interested in creating a new config file with just a single line with a dmenu command with cli flags. so uh how does that -l exception actually work? perhaps i can include additional exceptions on my own fork

Fuseteam commented 2 years ago

yay i finally figured it out~ i guess now i just need to figure out how to get the length of the longest line or something