search

firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
783 stars 74 forks source link

Add an exit option to keep the application running after each user choice #111

Closed amtoine closed 1 year ago

amtoine commented 1 year ago

This PR adds a loop around the action selection such that the application does not close after each choice of the user. An "exit" option also has been added to close the application properly.

Addresses #110.

firecat53 commented 1 year ago

I appreciate the effort! Try out the develop branch and see if that behaves like you would expect after a wifi rescan. I don't feel that keeping the script open after every action is necessary, but I've been struggling to figure out how to handle the rescan. Five seconds seems reasonable to me, but I only have one device to test it with! Let me know what you think.

firecat53 commented 1 year ago

I implemented a slightly different approach for handling the rescan. See my comments in #111.

amtoine commented 1 year ago

I appreciate the effort! Try out the develop branch and see if that behaves like you would expect after a wifi rescan. I don't feel that keeping the script open after every action is necessary, but I've been struggling to figure out how to handle the rescan. Five seconds seems reasonable to me, but I only have one device to test it with! Let me know what you think.

oooo i see :thinking: that could be enough you're right :open_mouth:

let me try that out and compare with what i've done :wink: i'll give you feedback asap :relieved:

amtoine commented 1 year ago

I implemented a slightly different approach for handling the rescan. See my comments in #111.

is it really in #111? :thinking: it links to this very PR :yum:

amtoine commented 1 year ago

i switch back to #110 to talk about that feature :wink:

amtoine commented 1 year ago

@firecat53 do we close this now? :thinking:

not directly connected to the new feature, but maybe overkill :wink:

firecat53 commented 1 year ago

Closed with e84118c