search

firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
783 stars 74 forks source link

Add a hint to check if NetworkManager is running #114

Closed brodokk closed 1 year ago

brodokk commented 1 year ago

Hello,

I'm not sure if this is the best way to detect if the NetworkManager is running but it seems to be the more global way.

Also I don't raise an error but prefer to print a warning message to avoid to kill the program if NetworkManager is not running in the case that the detection is wrong.

I made this PR because I had an issue with my fresh Arch install. NetworkManager was not started but the script don't say anything about it. I feel that at least a small warning, while the information could be sometime incorrect, is better than none when you open the connection manager and it just close without any information. Now if their is a better way to do it or just none im open to listen.

thanks again for this script!

firecat53 commented 1 year ago

I switch your check to a little more Pythonic and cross platform method and added a notification since most people will trigger the script from a keyboard shortcut and not see a print statement. Good idea for the PR, thanks!