firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
783 stars 74 forks source link

feat: customizable active prefix & highlighting style for wofi #124

Closed Alan-Kuan closed 7 months ago

Alan-Kuan commented 12 months ago

I added 2 features.

  1. customizable active prefix
    [dmenu]
    active_chars = v  # (default: ==)

image

  1. highlight active connection and customizable style for wofi I don't use other menus, and don't know whether it's possible there, so I only support wofi.

Warning There's a breaking change. I renamed rofi_highlight to highlight. In my opinion, it's better than introducing another wofi_highlight field.

[dmenu]
highlight = True

image

Default highlighting style is bold text.

The followings are fields for the highlighting style.

[dmenu]
highlight_fg = #f2b468
highlight_bg = black
highlight_bold = False

image

Please tell me what to do if I missed something. Thank you!

Alan-Kuan commented 11 months ago

Hi @firecat53,

Could you take a look at this and help me merge it? Thank you so much.

firecat53 commented 11 months ago

Patience my friend 😉 I will get to it when I have some free time. Thanks for the contribution!

Alan-Kuan commented 11 months ago

Thanks. I can wait until you're available.

joelsleeba commented 8 months ago

@Alan-Kuan I had implemented almost similar thing locally. Appreciate this pull request

firecat53 commented 7 months ago

Merged with some minor additions to docs. Thanks for the work!