search

firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
783 stars 74 forks source link

add ability to select gui #136

Closed lugeha closed 1 month ago

lugeha commented 1 month ago

If gnome is installed, but you are not in a gnome environment, gnome-control-center is still used. However, it will not work outside of gnome shells.

This PR adds the ability to select which GUI editor to use, the fallback value is still gnome-control-center.

However, this will break for people who do not have gnome installed as it will not fall through to nm-connection-editor.

Configuration example is as follows,

[editor]
gui = nm-connection-editor
firecat53 commented 1 month ago

I think I can agree with this PR.

  1. What do you think about having the fallback be nm-connection-editor instead? I think for the people likely to use this project, they are more likely to not be using Gnome and likely not be in a Gnome session.
  2. Can you also please update config.ini.example and the README to reflect your changes?

Thanks!

lugeha commented 1 month ago

Done.