search

firecat53 / networkmanager-dmenu

Control NetworkManager via dmenu
MIT License
812 stars 72 forks source link

bluetoothctl crashes sway WM #141

Open juleslink opened 3 months ago

juleslink commented 3 months ago

Hey there,

i am a huge fan of networkmanger-dmenu and was very disappointed that it crashed my sway WM while not being called from a terminal (calling it through rofi or keyboard shortcuts). If i call it from a terminal all is fine.

I am on Manjaro Sway.

I could track this down to your code around bluetoothctl. No clue why this happens. There is nothing special in the logs, sway just crashes.

But i made some changes to be able to choose between rfkill or bluetoothctl via the config.ini like

[bluetooth]

rfkill or bluetoothctl (Default: rfkill)

helper = rfkill

Not sure if you like this, but leave it here for reference, maybe it helps someone else.

networkmanager_dmenu_patch.txt

Keep up the good work, Best, Jules

firecat53 commented 2 months ago

Hmm, that's an odd failure! Sorry you were having issues!

It appears you basically want to skip all of the blutoothctl commands to prevent the crash?

Did you have bluetoothctl intsalled when it crashed?

Is rfkill present on your system?

When you say sway crashed, what do you mean? Did it freeze? Go back to the login screen? Restart?

juleslink commented 2 months ago

It appears you basically want to skip all of the blutoothctl commands to prevent the crash?

Yes, exactly!

Did you have bluetoothctl intsalled when it crashed?

Yes bluetoothctl is installed when it crashes.

Is rfkill present on your system?

Yes rfkill is also present, i use it now to switch Bluetooth on and off through networkmanager-dmenu and it works fine.

When you say sway crashed, what do you mean? Did it freeze? Go back to the login screen? Restart?

I am back at the login screen of sway when it crashes.

I just double-checked all your Bluetooth commands form terminal. Nothing triggers the crash, it just happens when not called from terminal.

Really clueless why this happens, so the only option for me is to disable the bluetoothctl part and only use rfkill.

firecat53 commented 2 weeks ago

Sorry, I am unable to replicate this at all! Without any reports from other users, we might have to chalk this up to something odd about your particular system. You could try running the commands using Popen from the python REPL and see if you can trigger the crash.