Closed Boruch-Baum closed 3 years ago
Thanks! Could you please update the README and man page with the new flag?
On 2021-04-24 10:08, Scott Hansen wrote:
Thanks! Could you please update the README and man page with the new flag?
Sure. I pushed a relevant commit a few seconds ago. Some questions, though.
1) Are you happy with the option name and short-cut -W and --whitespace-off?
2) The command line usage of the README (my line 112) is currently a single line, and the entries have no order that is discernible to me. Can I separate them into many lines, alphabetically ordered?
3) The ordering of options in the man page makes no sense to me. Can I sort them alphabetically?
4) The README omits information present in the man page. Do you want it included?
5) I'm attaching a snippet from my config.json for consideration as an additional or even default colorized palette.
-- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
"default": [
[
"header",
"brown",
"black",
"standout"
],
[
"footer",
"white",
"dark red",
"standout"
],
[
"search",
"white",
"dark green",
"standout"
],
[
"msgtext",
"light cyan",
"black"
],
[
"msgtext:ellipses",
"light gray",
"black"
],
[
"urlref:number:braces",
"light gray",
"black"
],
[
"urlref:number",
"yellow",
"black",
"standout"
],
[
"urlref:url",
"dark green",
"black",
"standout"
],
[
"url:sel",
"white",
"black",
""
]
1) Are you happy with the option name and short-cut -W and --whitespace-off?
Yep. If I have time, I might try to do what you did and code the toggle for it.
2) The command line usage of the README (my line 112) is currently a single line, and the entries have no order that is discernible to me. Can I separate them into many lines, alphabetically ordered? 3) The ordering of options in the man page makes no sense to me. Can I sort them alphabetically? 4) The README omits information present in the man page. Do you want it included?
Working on the docs would be awesome! All the above suggestions sound good to me. However, I'd ask that if you tackle that to put it into a separate PR.
5) I'm attaching a snippet from my config.json for consideration as an additional or even default colorized palette.
Haven't had time to check this out yet. Will do so soon!
Thanks for all the input and help!
The palette looks nice. I need to think about if I want to include a 3rd option. I don't think I'll replace the default. Maybe submit a PR including your palette as a 3rd default and I'll consider whether or not to add it. Thanks!
I originally wrote this for version 0.9.4 where some renderings had many consecutive lines of white-space. After upgrading to 0.9.6 in order to make the PR, I see that has been greatly reduced but I still like the compact look so I'm offering it as an option. I failed in an attempt to write a run-time toggle option for this feature.