search

firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
211 stars 36 forks source link

urlscan opens links in Firefox even though $BROWSER is set to qutebrowser #113

Closed Hund closed 3 years ago

Hund commented 3 years ago

I'm not sure if I'm doing something wrong here or what, but urlscan opens my links in Firefox even thought I have the variable $BROWSER set to qutebrowser --target private-window:

$ echo $BROWSER
qutebrowser --target private-window

I'm running version 0.9.6 on Gentoo.

firecat53 commented 3 years ago

It looks like the python browser module doesn't handle the extra arguments. Perhaps try some different quoting schemes or put the whole thing into a small shell script and set BROWSER to the shell script name. I know that works because that's what I've always done :)

wbob commented 3 years ago

I had xdg-settings get default-web-browser accidentally set to something different, maybe check this too?

Hund commented 3 years ago

It looks like the python browser module doesn't handle the extra arguments. Perhaps try some different quoting schemes or put the whole thing into a small shell script and set BROWSER to the shell script name. I know that works because that's what I've always done :)

I created the file browser.shwith the content:

#!/bin/bash
qutebrowser --target private-window $1

And then changed the variable to export BROWSER="browser.sh". This did not work, it still opens the links in the wrong web browser.

Edit: I forgot to make the file executable.. :|

firecat53 commented 3 years ago

Does that mean it's working properly now with the small script? That's what I've done for years.

Hund commented 3 years ago

Does that mean it's working properly now with the small script? That's what I've done for years.

Yes, it does. It seems like I was in a hurry, I didn't even said thanks.

Thank you!