search

firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
214 stars 38 forks source link

Updating tld generation to use a cached set of tlds from icann #33

Closed msmith491 closed 8 years ago

msmith491 commented 8 years ago

This should increase the number of matchable urls since icann increased the number of viable ones. Also added additional test cases for expected behavior.

A possible enhancement could be actively downloading the most recent version of this file available at http://data.iana.org/TLD/tlds-alpha-by-domain.txt. I opted to cache it because actively downloading the file would lead to additional unnecessary dependencies like requests. It would also break from the urlview behavior, which does not currently access any external assets when running.

firecat53 commented 8 years ago

Beautiful! I actually started something like this about 6 months ago, but never finished. Taking a closer look now...Thanks!!

firecat53 commented 8 years ago

I just made a couple of minor changes and merged. Thanks very much!

msmith491 commented 8 years ago

Awesome, thanks!