firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
214 stars 38 forks source link

Add numeric pad support #42

Closed pprw closed 6 years ago

pprw commented 6 years ago

It seems to me that urlscan should allow to select urls with the numbers intergrated to the keyboard. That is to say: when press 5, urlscan open in browser url 5. Now I have to use the arrow keys which is less effective.

firecat53 commented 6 years ago

Good idea!

firecat53 commented 6 years ago

Try out the develop branch and see if that works for you.

pprw commented 6 years ago

Thanks, I will test it.

I installed by mistake the master branch, I install just after the develop branch but I think it didn't erase the master branch. I have the message "urlscan 0.8.6 is already the active version in easy-install.pth" and the numeric pad does not work.

What is the proper way to remove urlscan? I installed the master branch with ./setup build and ./setup install.

firecat53 commented 6 years ago

If you installed it locally (as your user, not root), then you have to remove the urlscan files in ~/.local/bin and ~/.local/lib/pythonx.x/site-packages.

If you experiment much with installing python applications, definitely learn how to use virtualenv's. They will keep the applications isolated and easy to uninstall (just delete the virtualenv).

pprw commented 6 years ago

Ok I managed to uninstall and install the develop branch.

It works fine. I propose, for maximum efficiency, to remove the step "press enter". You press 2 and the url 2 is loading.

firecat53 commented 6 years ago

Two reasons why this won't work:

  1. There's no way to discern numbers with more than 1 digit.

  2. If you type the wrong number it won't automatically launch the url. Gives you a chance to move to the correct one.

pprw commented 6 years ago

Yes it makes sense.

<number>+<ENTER> is already a good amelioration. Thanks !