firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
214 stars 38 forks source link

Unreadable urls #46

Closed kflak closed 6 years ago

kflak commented 6 years ago

Hi,

Thanks for a great tool! However, I have a problem reading the urls that are in focus, both when running a dark and a light gruvbox-inspired theme in xfce4-terminal. The problem is that the selected links are dark grey on a darkish-blue background, which is obviously a bit hard to make out. I tried this with the default mutt color-scheme, as well as a light and a dark gruvbox-theme. Any solutions much appreciated! I am on Arch Linux/i3wm

firecat53 commented 6 years ago

This might take awhile to fix. I have to figure out whether to use command-line switches, a config file, or some way to cycle through colors on the fly. Right now, the palette is hard coded into urlchoose.py (line 155 self.palette). If you can't find a terminal theme that works for you, you could install urlscan from git and play with the colors in self.palette until I can make it configurable.

Edit: If you do decide to fiddle with the code, the two lines that affect the URL display are

('urlref:url', 'white', 'black', 'standout')
('url:sel', 'white', 'dark blue', 'bold')` 

The URWID palette colors and examples are here: http://urwid.org/manual/displayattributes.html?#standard-foreground-colors

kflak commented 6 years ago

Thanks for the response! Will take a look at the git version when I have a bit more time on my hands.

On 12 Apr 2018 19:01, Scott Hansen wrote:

This might take awhile to fix. I have to figure out whether to use command-line switches, a config file, or some way to cycle through colors on the fly. Right now, the palette is hard coded into urlchoose.py (line 155 self.palette). If you can't find a terminal theme that works for you, you could install urlscan from git and play with the colors in self.palette until I can make it configurable.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.*

firecat53 commented 6 years ago

Hey, give the develop branch a try and see what you think. Added a black & white palette and a config file can be generated for editing/adding palettes.

kflak commented 6 years ago

Oh sweet! The black and white theme works miracles for visibility. Thanks a lot for this :-)