search

firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
213 stars 37 forks source link

Open URL in running instance #73

Closed 4217th closed 5 years ago

4217th commented 5 years ago

Is it possible to get urlscan to open new tabs in a running browser instance, rather than opening an instance which then blocks mutt/urlscan? I cant find a way to configure what happens when enter is pressed on a selected url...

firecat53 commented 5 years ago

On September 13, 2018 6:26:13 AM PDT, 4217th notifications@github.com wrote:

Is it possible to get urlscan to open new tabs in a running browser instance, rather than opening an instance which then blocks mutt/urlscan? I cant find a way to configure what happens when enter is pressed on a selected url...

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/firecat53/urlscan/issues/73

From the README:

To choose a particular browser, set the     environment variable BROWSER. If BROWSER is not set, xdg-open will control which browser is used, if it's available.:

    export BROWSER=/usr/bin/epiphany

It "just works", opening tabs in a running browser instance without blocking. There are some apps that block (Libreoffice if I remember right) when opened via xdg-open but browsers aren't one of them. I've used urlscan with Firefox, Chrome and qutebrowser without any trouble.

4217th commented 5 years ago

I'm using qutebrowser (export BROWSER=/usr/bin/qutebrowser) and the macro provided in the urlscan README and urlscan opens a new window and is blocked until that process is killed.

eg I use urlscan to open a link, switching back to urlscan won't let me select another link or return to the email without closing the browser itself or keyboard-interrupt in the urlscan/mutt shell.

edit: I just tried with reddit terminal viewer and here urlscan works as expected, so there seems to be something wrong with my mutt config.

I don't have any special settings in my muttrc that I know of, though

firecat53 commented 5 years ago

On September 13, 2018 7:42:23 AM PDT, 4217th notifications@github.com wrote:

I'm using qutebrowser (export BROWSER=/usr/bin/qutebrowser) and the macro provided in the urlscan README and urlscan opens a new window and is blocked until that process is killed.

eg I use urlscan to open a link, switching back to urlscan won't let me select another link or return to the email without closing the browser itself or keyboard-interrupt in the urlscan/mutt shell.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/firecat53/urlscan/issues/73#issuecomment-421031791

You've got something else funky going on with your setup, I think. That's exactly the configuration I use and other people use without any issue.

What distro are you using? Python version? Terminal? I can see if I can replicate in a VM.

4217th commented 5 years ago

Turns out I need to select urls with "space" when I use URLscan in mutt while in eg reddit terminal browser "cr" works aswell

Not sure if I'm an idiot and this should have been obvious or if this weird behaviour (I'm fairly new to mutt)

firecat53 commented 5 years ago

No, 'Enter' works just like 'space' on my machine. Never heard of anyone having trouble with that. It's wired into the Urwid module. There's nothing in urlscan that drives which key opens the url. Maybe check what versions of urwid and python you have installed?

firecat53 commented 5 years ago

Any other info or changes with your issue/setup?

firecat53 commented 5 years ago

Closing...let me know if you have any more trouble with it.