search

firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
214 stars 38 forks source link

Add shortcut to copy link #78

Closed matt-snider closed 5 years ago

matt-snider commented 5 years ago

Would it be within scope of the project to add a shortcut for copying the link instead of opening it? I think this is an important feature. Currently it's not possible AFAIK to copy the link, since attempting to highlight it results in it being opened.

I am aware of the --run argument, but I think copying is fundamental enough that it warrants its own permanent shortcut. Also, within the same session a user may want to open some URLs, but copy others.

firecat53 commented 5 years ago

Added copy to clipboard with C. Check out the develop branch and see if it works for you. Requires xsel or xclip. Thanks!

matt-snider commented 5 years ago

@firecat53 Awesome! That's great :+1:

One thing you might consider is using the XA_CLIPBOARD since that is the one used by most applications for Ctrl+X/Ctrl+C/Ctrl+V. I commented about that on the commit here. But different people might have other opinions on this. You could also make it configurable.

Either way, works for me :smile:

firecat53 commented 5 years ago

Valid consideration. I don't know the right answer as to which clipboard to use. My inclination is to use primary, since urlscan users are most likely to be more advanced and conversant in terminal/clipboard usage. I could make it configurable, but I think I'll leave it as primary for now for simplicity's sake unless for some reason I get a large number (hahaha) of people requesting the clipboard instead.

matt-snider commented 5 years ago

Sounds good to me. Seeing as this appears to be the first request for clipboard support, I think keeping it simple is a good choice. Thank you for implementing this!

On January 21, 2019 10:50:59 PM UTC, Scott Hansen notifications@github.com wrote:

Valid consideration. I don't know the right answer as to which clipboard to use. My inclination is to use primary, since urlscan users are most likely to be more advanced and conversant in terminal/clipboard usage. I could make it configurable, but I think I'll leave it as primary for now for simplicity's sake unless for some reason I get a large number (hahaha) of people requesting the clipboard instead.