firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
214 stars 38 forks source link

Do not support parenthesis in URLs #9

Closed ghost closed 9 years ago

ghost commented 9 years ago

forwarded from: https://bugs.launchpad.net/ubuntu/+source/urlscan/+bug/385955 To reproduce:

 echo '\nhttp://github.com/(firecat53)/urlscan'|urlscan

From: http://tools.ietf.org/html/rfc3986#page-12


2.2. Reserved Characters

URIs include components and subcomponents that are delimited by characters in the "reserved" set. These characters are called "reserved" because they may (or may not) be defined as delimiters by the generic syntax, by each scheme-specific syntax, or by the implementation-specific syntax of a URI's dereferencing algorithm. If data for a URI component would conflict with a reserved character's purpose as a delimiter, then the conflicting data must be percent-encoded before the URI is formed.

  reserved    = gen-delims / sub-delims

  gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"

  sub-delims  = "!" / "$" / "&" / "'" / "(" / ")"
              / "*" / "+" / "," / ";" / "="
ghost commented 9 years ago

Forwarded to Debian BTS https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=771506

ghost commented 9 years ago

see https://github.com/firecat53/urlscan/pull/12

firecat53 commented 9 years ago

Fixed by #12