search

firecat53 / urlscan

Mutt and terminal url selector (similar to urlview)
GNU General Public License v2.0
213 stars 37 forks source link

Only work around webbrowser bug if needed. #96

Closed ryneeverett closed 4 years ago

ryneeverett commented 4 years ago

This should resolve #94 as much as it can be.

My primary motivation however is to avoid overriding the predefined browser types when possible. A lot of work has gone into making the predefined types work well and we should have advantage of them.

firecat53 commented 4 years ago

Couple of questions:

  1. Do we even need this whole workaround any more? The bug report says it's been closed/fixed since 2018.
  2. Does my browser_var_empty work for you? It basically just removes the workaround entirely.

Thanks for working on this!

ryneeverett commented 4 years ago

Feel free to close and go the deletion route, I just threw this out there as a backwards compatible alternative in case there were reservations with that approach.

ryneeverett commented 4 years ago

The bug must have only existed in a few old patch releases so I say delete!

firecat53 commented 4 years ago

That's my inclination as well. I'd just like to make sure the OP from #94 is able to get things working as they're supposed to. Thanks!